mirror of
https://github.com/veekun/pokedex.git
synced 2024-08-20 18:16:34 +00:00
e6b64b8c5a
The previous commit added a nullable subtitle field to location_names. This caused a test in test_schema.py to fail because the name field wasn't also nullable. A comment above the test says, "If there's more than one text column in a translation table they have to be nullable, to support missing translations", but i don't think that logic holds in this case. The idea is that we might have a translation for the subtitle, but not the name, or vice versa, so both need to be nullable in case one or the other is missing. But in this particular case that doesn't make sense: if you don't have a name, you don't have a location; it may or may not have a subtitle, but a location will always have a name. Therefore, add an exception to the test. |
||
---|---|---|
.. | ||
cli | ||
data/csv | ||
db | ||
doc | ||
struct | ||
tests | ||
util | ||
__init__.py | ||
__main__.py | ||
compatibility.py | ||
defaults.py | ||
formulae.py | ||
lookup.py | ||
main.py | ||
roomaji.py | ||
search.py |