This commit originally included Basculin, too, but then magical dealt
with that before I pushed. Anyway, the query I used should have caught
any other similar cases, too:
insert into pokemon_moves select p.id, 14, pm.move_id, 2, 0, null from
pokemon_moves pm
join pokemon p on pm.pokemon_id=p.species_id and p.is_default=false
where pm.version_group_id=14 and pm.pokemon_move_method_id=2;
The join condition is cheating a little, but it does happen to work; it
joins a pokemon_move to all non-default forms of the same Pokémon. If
being default and having id=species_id didn't go hand-in-hand, I'm
pretty sure it'd require two joins to pokemon.
I'm assuming Normal Deoxys learns tutors based on Speed Deoxys's list,
given that Attack and Defense Deoxys have all the same tutors, and Speed
Deoxys has all those same tutors too while only gaining tutors unique to
Emerald. So in other words, it looks like Deoxys's Forme doesn't matter
for tutor compatibility in Gen III.
Also worth noting: I gave the alternate forms their respective moves
even though they technically learn them specifically in their default
forms. It seems weird to say that only one form gets the move,
especially when learning Secret Sword immediately causes Keldeo to /not/
be its default form. Also, Pirouette Meloetta already has TMs and other
tutors even though it's battle-only.
I noticed that the Togepi line was also missing Magic Coat when I went to
double-check Togetic's Twister. I checked Togepi and Togekiss and added
that, too.
Level up, TM, and tutor moves have already been ripped, so this should
be the last.
There are no changes (from what we had before) to Crystal, and only a
few additions to Gold/Silver.
Also, just to be safe, i checked that the egg moves in Silver are the
same as in Gold.
Thanks once again to UPC--it's easier to find something when you know
what you're looking for.
The Gen III data didn't have any errors, and I assume our Gen IV data is
much more recent and trustworthy and isn't worth checking. Crystal
tutor compatibility is stored right after HMs, so it was easy; I don't
know about any other tutors.
This also fixes an absolute TON of errors with evolved Pokémon learning
a move both at level 1 and the pre-evolution's level, as well as
miscellaneous other problems.