From f4c51c845dbbeb3a43f3391f767a220b12be6e79 Mon Sep 17 00:00:00 2001 From: Andrew Ekstedt Date: Tue, 5 Jun 2012 18:10:37 -0700 Subject: [PATCH] Sort relationship docs alphabetically. Creation order wasn't that big of a win and didn't play nicely with backrefs. --- pokedex/doc/tabledoc.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/pokedex/doc/tabledoc.py b/pokedex/doc/tabledoc.py index a24c82d..172a454 100644 --- a/pokedex/doc/tabledoc.py +++ b/pokedex/doc/tabledoc.py @@ -204,14 +204,11 @@ def generate_relationships(cls, remaining_attrs): def isrelationship(prop): return isinstance(prop, InstrumentedAttribute) and isinstance(prop.property, RelationshipProperty) - relationships = [] - for attr_name in remaining_attrs: + for attr_name in sorted(remaining_attrs): prop = getattr(cls, attr_name) - if isrelationship(prop): - relationships.append((attr_name, prop.property)) - relationships.sort(key=lambda x: x[1]._creation_order) - - for attr_name, rel in relationships: + if not isrelationship(prop): + continue + rel = prop.property yield u'%s.\ **%s**' % (cls.__name__, attr_name) class_name = u':class:`~pokedex.db.tables.%s`' % rel.mapper.class_.__name__ if rel.uselist: