From 85ee27dedde70358f7c07938e59e349d54f73377 Mon Sep 17 00:00:00 2001 From: Eevee Date: Wed, 25 Mar 2009 20:43:09 -0400 Subject: [PATCH] Fixed CSV import's handling of Boolean columns. --- pokedex/__init__.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/pokedex/__init__.py b/pokedex/__init__.py index 2932504..d60224e 100644 --- a/pokedex/__init__.py +++ b/pokedex/__init__.py @@ -1,6 +1,8 @@ # encoding: utf8 import sys +import sqlalchemy.types + from .db import connect, metadata def main(): @@ -49,9 +51,17 @@ def csvimport(engine_uri, dir='.'): row = table() for column_name, value in zip(column_names, csvs): - if table.__table__.c[column_name].nullable and value == '': + column = table.__table__.c[column_name] + if column.nullable and value == '': # Empty string in a nullable column really means NULL value = None + elif isinstance(column.type, sqlalchemy.types.Boolean): + # Boolean values are stored as string values 0/1, but both + # of those evaluate as true; SQLA wants True/False + if value == '0': + value = False + else: + value = True else: # Otherwise, unflatten from bytes value = value.decode('utf-8')